SkyAPM / go2sky

Distributed tracing and monitor SDK in Go for Apache SkyWalking APM
https://skywalking.apache.org/
Apache License 2.0
448 stars 123 forks source link

hope reporter support logger interface{} #66

Closed cclehui closed 4 years ago

cclehui commented 4 years ago

Is your feature request related to a problem? Please describe. our application use self defined logger module , which is not log.Logger . but implements level logger interface{} .

but the reporter.grpc.WithLogger(logger log.Logger) only support log.Logger

type LevelLogger interface { Debug(msg string) Debugf(format string, v ...interface{}) Info(msg string) Infof(format string, v ...interface{}) Warn(msg string) Warnf(format string, v ...interface{}) Error(msg string) Errorf(format string, v ...interface{}) }

Describe the solution you'd like define a logger interface , so we can overwrite

wu-sheng commented 4 years ago

I don't think we should define a duplicated logger interface. Especially, golang has one already.