search

SkyAPM / go2sky

Distributed tracing and monitor SDK in Go for Apache SkyWalking APM
https://skywalking.apache.org/
Apache License 2.0
448 stars 122 forks source link

Add tracer sampler #73

Closed xbkaishui closed 3 years ago

xbkaishui commented 4 years ago

Fix #70 , support client side trace sampling service.

xbkaishui commented 4 years ago

@arugal, I have changed the logic , please help to check if it is acceptable, thanks

codecov-commenter commented 3 years ago

Codecov Report

Merging #73 into master will decrease coverage by 0.46%. The diff coverage is 63.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
- Coverage   69.59%   69.12%   -0.47%     
==========================================
  Files          12       13       +1     
  Lines         638      677      +39     
==========================================
+ Hits          444      468      +24     
- Misses        158      171      +13     
- Partials       36       38       +2
Impacted Files Coverage Δ
trace_opts.go 37.50% <0.00%> (-62.50%) :arrow_down:
trace.go 80.18% <58.33%> (-3.15%) :arrow_down:
sampler.go 100.00% <100.00%> (ø)
span_opts.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fdae247...e28762a. Read the comment docs.

xbkaishui commented 3 years ago

@arugal , changed as your request, please help to check again. Thanks

JuankleChan commented 3 years ago

can this commit merger into v0.3 & v0.4 branch ?

arugal commented 3 years ago

can this commit merger into v0.3 & v0.4 branch ?

v0.3.0 and v0.4.0 is tag.

JuankleChan commented 3 years ago

can this commit merger into v0.3 & v0.4 branch ?

v0.3.0 and v0.4.0 is tag.

what shoud i do if i want tracer sampler but the oap version must be v6.4.0? is it possible to new a branch for adapting the old grcp protocol?