search

SkyAPM / go2sky

Distributed tracing and monitor SDK in Go for Apache SkyWalking APM
https://skywalking.apache.org/
Apache License 2.0
447 stars 122 forks source link

Using skywalking goapi as protocol #98

Closed mrproliu closed 3 years ago

mrproliu commented 3 years ago

Using SkyWalking GoAPI as protocol, remove self-build protocol files

mrproliu commented 3 years ago

Hi, @kezhenxu94. The redundant aliases are generated by goimports plugin. If I remove it, it will throw an error in the lint phase.

kezhenxu94 commented 3 years ago

Hi, @kezhenxu94. The redundant aliases are generated by goimports plugin. If I remove it, it will throw an error in the lint phase.

That’s weird, anyway, it looks good to me

kezhenxu94 commented 3 years ago

After reading the issues, I think the aliases are inevitable, but I'd suggest use agentv3 as alias for "skywalking.apache.org/repo/goapi/collect/language/agent/v3"

wu-sheng commented 3 years ago

After reading the issues, I think the aliases are inevitable

Could you explain a little? @kezhenxu94

wu-sheng commented 3 years ago

After reading the issues, I think the aliases are inevitable

Could you explain a little? @kezhenxu94

OK, I can see this is useful in the client.go as it needs v3.SpanLayer_Http. @mrproliu Please follow the renaming suggestion.