SkyCryptWebsite / SkyCrypt

A Hypixel skyblock stats website
https://sky.shiiyu.moe
MIT License
248 stars 125 forks source link

Tecture Pack inconsistency #2201

Open kada49 opened 4 months ago

kada49 commented 4 months ago

Describe the bug Rift collections have custom tp icons even with just vanilla tp enabled.

Profile/Location https://sky.shiiyu.moe/stats/kada49/Raspberry#Collections

Expected behavior SHow player heads like in the boss collections in the category below.

Screenshots Screenshot from 2024-03-03 20-39-47 WhatsApp Image 2024-03-03 at 20 49 14

Desktop (please complete the following information):

Smartphone (please complete the following information):

github-actions[bot] commented 4 months ago

This looks like your first issue on SkyCrypt! Thank you for bringing this issue to our attention. Expect a developer to comment within the first 3-5 business days of issue submission.

TheTrueShaman commented 4 months ago

I can confirm that this issue also occurs on desktop. The issue is also present for the Magmafish, Chili Pepper, Sulphur, Hard Stone and Gemstone collections. I will look further into this issue to see if I can solve it.

kada49 commented 3 months ago

I also found that the mithril collection has the same issue

TheTrueShaman commented 3 months ago

I have just identified the source of the issue. The issue stems from the file following file: src/scripts/update-collections.js, more specifically on line 22. This code automatically takes the ID of item (from API), and adds that as the texture of the item. I'll see if I can fix this behavior at a later time, unless you or someone else is willing to resolve this issue soon.

TheTrueShaman commented 2 months ago

Turns out, I have no idea how to test changes with texture packs (when I launch development servers it has no working textures), so I can't really help with this, at least not with the knowledge I have right now.