SkyD666 / AniVu

All-in-one Android app for RSS, BitTorrent dl & play. MVI arch, Material You style. ⭐️ Star to support! 一站式 RSS 订阅、BitTorrent 下载和媒体播放 Android 应用。采用 MVI 架构和 Material You 风格。⭐️点个 Star 以支持工作
https://t.me/SkyD666Chat
GNU General Public License v3.0
421 stars 10 forks source link

Can the bullet chat be added? #47

Open NeKoOuO opened 1 month ago

NeKoOuO commented 1 month ago

現階段的感覺已經非常完善了,下載觀看一條龍,要是能有彈幕功能那追番體驗會上一層樓,想建議加入彈彈的彈幕源,使用弹弹play开放平台 加上 Bangumi Api 來實現彈幕功能,像是KNKPAnime的彈幕功能就做的挺好的和官方的DanDanPlayForAndroid,下面有幾個是其他項目使用的類似案例

https://github.com/open-ani/ani https://github.com/Predidit/Kazumi https://github.com/Predidit/oneAnime

想問問您的意見和想法

SkyD666 commented 1 month ago

弹幕的话可以考虑,但bangumi api可能不会加入,因为会增加app依赖某个特定平台的程度,而我希望能够尽量提高app通用性

SkyD666 commented 1 month ago

你知道目前还在维护的开源弹幕库有哪些吗?

NeKoOuO commented 1 month ago

https://github.com/OpenDanmakuCommunity/awesome-danmaku 這邊感覺可以參考下

Luffyirl commented 1 month ago

弹幕的话可以考虑,但bangumi api可能不会加入,因为会增加app依赖某个特定平台的程度,而我希望能够尽量提高app通用性

Wont this make the app dependent on a online service ? Have u really make ur mind adding the feature or is it open to debate for implementation? .

I'm really opposed to the suggestion. The app is so close to complete I'd rather want improvement in other parts instead of a service linked to it .

Being able to run without any dependencies is waht makes anivu great and thats why i love ♥️ it .

And barrage file import is gud .

NeKoOuO commented 1 month ago

@Luffyirl This feature is essentially switchable and should not have dependency issues. It's more like an extension; even if it's absent or not working, it won't cause any problems.

SkyD666 commented 1 month ago

I think there should be more isolation and abstraction between external services and app

Ripl0gic commented 1 month ago

@Luffyirl This feature is essentially switchable and should not have dependency issues. It's more like an extension; even if it's absent or not working, it won't cause any problems.

Will it be online tho ? Coz having a online service linked isn't what most people prefer when they torrent. If i can grab the XML or JSON file from Niconico/Acfun/Bilibili and import it to the app then it'd better.

Ripl0gic commented 1 month ago

Probably some kind of extension based system for importing the files would be much better.

I remember someone mentioning torrentio search Engine ( which is also a very great and organised Library for searching through media torrents) in teligram. But aain thats a online service which makes the app dependent on that.

But if its like a extension module then only people who want to use the extension can use download it .

I don't remember the app name correctly but there is a great app which has extension based system for watching content. That can be taken as inspiration.

Luffyirl commented 1 month ago

Probably some kind of extension based system for importing the files would be much better.

I remember someone mentioning torrentio search Engine ( which is also a very great and organised Library for searching through media torrents) in teligram. But aain thats a online service which makes the app dependent on that.

But if its like a extension module then only people who want to use the extension can use download it .

I don't remember the app name correctly but there is a great app which has extension based system for watching content. That can be taken as inspiration.

Yep this would also improve the isolation between the app and external services . Also if someone wants to make their own extension they won't have to interact with the main app code to understand it , they can just take inspiration for the example extension module and how it sends info to the app.

Bubblekey commented 1 month ago

I don't remember the app name correctly but there is a great app which has extension based system for watching content. That can be taken as inspiration.

U probably mean Aniyomi (better for kuukiyomi) or tachiyomi/mihon

Another advantage is if u add extension service then if some content provider claims a dmca lawsuit then it would only apply to the extension repo and not the main app so u can just take down that extension or move the repo . So no reputational harm for main app repository.

All the apps mention has been greatly successful in what they do .

NeKoOuO commented 1 month ago

But I think simple bullet chat service should not have any infringement issues, right?

NeKoOuO commented 1 month ago

@Luffyirl This feature is essentially switchable and should not have dependency issues. It's more like an extension; even if it's absent or not working, it won't cause any problems.

Will it be online tho ? Coz having a online service linked isn't what most people prefer when they torrent. If i can grab the XML or JSON file from Niconico/Acfun/Bilibili and import it to the app then it'd better.

@SkyD666 @Ripl0gic I think an interesting point mentioned is importing through downloading XML files, and now the official Android version also uses a similar function, so I think we can follow the official practice

Bubblekey commented 1 month ago

But I think simple bullet chat service should not have any infringement issues, right?

Yeh this is like subtitle file right ? It won't have any problems I think.