search

SkyLothar / lua-resty-jwt

JWT For The Great Openresty
Apache License 2.0
513 stars 178 forks source link

Review CI #59

Closed lucafavatella closed 7 years ago

lucafavatella commented 7 years ago

Closes #58.

lucafavatella commented 7 years ago

I am testing locally fix for failures.

lucafavatella commented 7 years ago

I am testing locally fix for failures.

My attempt failed so do not hold your breath.

lucafavatella commented 7 years ago

I fixed the tests and pushed in this branch but I would need review: the syntax looked invalid (I am not a Lua expert) and after changing syntax the error string changed - not sure how relevant the specific error is. Review welcome.

SkyLothar commented 7 years ago

Thanks for fixing ci and tests. Using docker-compose as test command is really a bad idea 😞