search

SkyLundy / Fluency

The complete translation enhancement suite for ProcessWire
GNU General Public License v3.0
17 stars 1 forks source link

ProcessWire admin top navbar sometimes disappears when clicking on the standalone "Translation" menu. #7

Open yuters opened 4 months ago

yuters commented 4 months ago

When clicking on the top menu "Translation" either from the "Setup" or "Access" menu, the ProcessWire admin top navbar disappears.

When clicking from "Pages" it shows as a modal. When clicking from "Modules" it shows as a new page, and the top nav is still there.

I'm not sure what the intended behaviour should be, would it be best to have it as a modal all the time?

Thanks!

SkyLundy commented 4 months ago

@yuters Unfortunately it's a known issue that I hadn't documented since I wasn't sure how often it would come up (if at all). Since it was limited to areas only superusers would access I didn't think to look further into resolving it. Is it an issue that is disruptive to your workflow? Any areas where per-field translation isn't available and you are reliant on the menu bar translation tool?

It's something that I can take a look at again to include in a future release.

yuters commented 4 months ago

@SkyLundy It's not a big issue right now.

I just @ you in the ProcessWire forums regarding a glossary feature with DeepL. If I add this feature in a pull request, I was thinking of making it available to others than superusers, so instead of putting this in the settings, there would be a new Fluency Process page to manage glossaries, so then the menu thing becomes an issue.

SkyLundy commented 4 months ago

@yuters I'm writing my response as we speak haha. Sharing some insight into reasoning on final/unhookable/private methods. We'll keep this convo going. Your ideas is great!