SkyTemple / ExplorerScript

ExplorerScript and SSBScript: Script languages for decompiled SSB (Pokémon Mystery Dungeon Explorers of Sky)
MIT License
16 stars 6 forks source link

Fix offset rewriting #18

Closed Frostbyte0x70 closed 2 years ago

Frostbyte0x70 commented 2 years ago

Recently reported at: https://discord.com/channels/710190644152369162/787260430728691712/921138547388452905

Seems like there were a couple of problems with the way offsets were rewritten, which sometimes caused an error when trying to save scripts that contained macro calls. Those scripts compile successfully and work as they should after applying the fix.

I can't say for sure that the logic of the method is 100% correct (the output works but seems overcomplicated, see Discord thread for details), but at least it works I guess.

Fixes #8.

theCapypara commented 2 years ago

Wow thank you!