Minor improvements to BoldText and ChangeTextSound

SkyTemple / skytemple-files

Python library to edit the ROM of Pokémon Mystery Dungeon Explorers of Sky (EU/US)

GNU General Public License v3.0

19 stars 24 forks source link

Minor improvements to BoldText and ChangeTextSound #528

Closed Adex-8x closed 3 months ago

Adex-8x commented 3 months ago

Some minor improvements to two patches:

BoldText: When characters' widths are read while bold text is active, then it will be increased by 1 to prevent characters from bleeding into one another.
ChangeTextSound: Added an optional second parameter to the text tag specifying the volume. If the text tag is used without a volume parameter, it defaults to 256.

github-actions[bot] commented 3 months ago

Test Results

14 files ±0 14 suites ±0 52m 46s :stopwatch: -6s 10 894 tests ±0 10 893 :white_check_mark: ±0 1 :zzz: ±0 0 :x: ±0 32 848 runs ±0 26 104 :white_check_mark: ±0 6 744 :zzz: ±0 0 :x: ±0

Results for commit 5668d403. ± Comparison against base commit 6da487af.