Improve Sprite Import Algorithm

SkyTemple / skytemple-files

Python library to edit the ROM of Pokémon Mystery Dungeon Explorers of Sky (EU/US)

GNU General Public License v3.0

19 stars 24 forks source link

Improve Sprite Import Algorithm #530

Closed irdkwia closed 3 months ago

irdkwia commented 3 months ago

This improves frame chunking algorithm to use minimal amount of blocks in VRAM for minimal Sprite Size. This algorithm has some effects on the Sprite File Size, tends to slightly increase it but can also slightly decrease it.

marius851000/pmd_wan#4 should also be merged to fix wrong maximum amount of blocks, which tends to overestimate Sprite Size value.

See #248

Contains also changes to Sprite Size calculation, so this should be merged at the same time as Skytemple/skytemple#785

github-actions[bot] commented 3 months ago

Test Results

14 files ±0 14 suites ±0 53m 26s :stopwatch: +48s 10 900 tests ±0 10 899 :white_check_mark: ±0 1 :zzz: ±0 0 :x: ±0 32 896 runs ±0 26 128 :white_check_mark: ±0 6 768 :zzz: ±0 0 :x: ±0

Results for commit a15da1fa. ± Comparison against base commit 88185334.

:recycle: This comment has been updated with latest results.