SkyTemple / skytemple

GUI Application to edit the ROM of Pokémon Mystery Dungeon Explorers of Sky
GNU General Public License v3.0
194 stars 21 forks source link

[JP] IQ Skills are misaligned #603

Closed Laioxy closed 1 year ago

Laioxy commented 1 year ago

I checked by loading the JP ROM(vanilla) on Nightly version and it seems that the IQ Skills are off. capture

In the image, the IQ Skill for ID7 is "PP Checker", IQ Points is "40", Restriction Group is "7", and all groups appear to have been mastered. Originally PP Checker should be unused and IQ Points should be set to 9999 and not belong to any group. Seeing that I haven't received any specific remarks about it so far, I think it's a JP version only phenomenon, what do you think?

Adex-8x commented 1 year ago

Hm, could it be that the Text Strings are incorrect? In NA/EU ROMs, ID 1 should be "Type-Advantage Master", or "あいしょうばつぐん". It looks like the IQ skills' groups are in-order, just that the names are off by one.

theCapypara commented 1 year ago

This is for the NA ROM. grafik

So 6 is not PP Checker in the JP ROM? It might be that the symbols are wrong or the text strings.

theCapypara commented 1 year ago

Ah what @Adex-8x said could be correct. It is specified here: https://github.com/SkyTemple/skytemple-files/blob/master/skytemple_files/_resources/ppmdu_config/pmd2data.xml#L262