search

SkyTubeTeam / SkyTube

Copylefted libre / open source YouTube player for Android
GNU General Public License v3.0
2.22k stars 318 forks source link

New release - version v2.988 #1253

Closed gzsombor closed 2 months ago

drogga commented 2 months ago

@gzsombor

https://github.com/SkyTubeTeam/SkyTube/blob/master/README.md#contribute This project was possible with the support and contribution of numerous volunteers and third-party projects. > Still leads to the dead site: http://skytube-app.com/credits.html, the link should be removed, or replaced for example with (unreliable): https://web.archive.org/web/20220123174541/https://skytube-app.com/credits.html or https://github.com/SkyTubeTeam/SkyTube/graphs/contributors The dead site's link is also available here and IDK if you can edit to remove it: https://github.com/SkyTubeTeam

Here as well: https://github.com/SkyTubeTeam/SkyTube/deployments/github-pages and on weblate (the "info" tab).

Also https://github.com/SkyTubeTeam/SkyTube#download > Please add the GH releases direct link to the Oss column, below, before or next to the F-Droid link, example: https://github.com/SkyTubeTeam/SkyTube/releases/download/v2.988/SkyTube-Oss-2.988.apk and btw, the direct ones can probably be replaced with /latest, which you won't have to edit the ReadMe for, every time there's a new release, even tho there are 2 assets (I can't currently provide an example link).

Preferences > About > Credits is clickable and leads to 404: Not Found, because it leads to https://raw.githubusercontent.com/SkyTubeTeam/SkyTube/master/contributors.txt in /app/build.gradle, which .txt file doesn't even exist in the repo and this should've been a link to whatever, instead of using a WebView. On the same menu/page > Copylefted Libre License: https://github.com/SkyTubeTeam/SkyTube/blob/59c27f33b5e7fb5e084f966a20e7f9ab5e020834/app/src/main/res/values/strings_preferences.xml#L112 ^ isn't this supposed to be clickable ?, because it's broken.

Videos with multi-channel / multilingual audio are not in English, you can check a video by MrBeast when using Dash/HLS (with the "Try newer Video formats" option, which is enabled by default anyway), it's the same in the prev. ver.

Often and in many cases the avatars/logos and channels header image (which is basically unnecessary, so much wasted space on top, with tabs always visible...) no longer seem to load.

drogga commented 2 months ago

I wonder if any of this also concerns and is problematic for @IzzySoft's repo as well...

I know that most are minor things, except the last part, of which I really didn't wanted to create a separate issue ticket for and I didn't posted in the discussions on purpose (bad experience there in the past).