SkyTubeTeam / SkyTube

Copylefted libre / open source YouTube player for Android
GNU General Public License v3.0
2.35k stars 326 forks source link

Background playback #143

Open avently opened 7 years ago

avently commented 7 years ago

This issue about https://github.com/ram-on/SkyTube/issues/6 You didn't answer to me so i created new issue. I added background playback to SkyTube from NewPipe. Most of the code i got from NewPipe and adapted it to SkyTube "reality". I'm not a Java programmer so expect bad practics in code. That's why i'm posting it here as a patch. You can try it and if you'll like it you can add it to your repo. It is not a 100% good solution but it works for me like i want it to work. Hope you'll find time and make this solution better. P.S. Thanks goes to NewPipe devs.

cd SkyTube git apply "backgroundplayback.txt location" backgroundplayback.txt

ram-on commented 7 years ago

Hi @avently thanks for your input. i'll look into it.

avently commented 6 years ago

@ram-on is doing nothing with this issue so, guys, feel free to use my fork if you want background playback and swipe controls in SkyTube https://github.com/avently/skytube

ram-on commented 6 years ago

@avently can you update your fork to use the latest https://github.com/ram-on/extractor.git ? I'd like to try it out after that.

avently commented 6 years ago

@ram-on done

strk commented 6 years ago

@avently do you publish an .apk for your fork version?

avently commented 6 years ago

@strk no. It doesn't have new features from original app because it is a little bit outdated. Maybe in the future background playback will be here too

rmenessec commented 6 years ago

I'd really like to see basic support background playback, even if it doesn't have notification controls to begin with. I'm using NewPipe in the meantime.

Davy49 commented 6 years ago

Hi, The last time I tried using the New Pipe application, it wouldn't allow me to play videos in the background either. As I remember, previously when I had a different version of the app installed, it did in fact allow background playing of videos, so I uninstalled the app and tried a different application ( Sky Tube ), now I'm having the same issue of playing videos in the background with it. David

ram-on commented 6 years ago

Background play is currently partially supported. If the app is minimized, the video will still continue playing.

avently commented 6 years ago

@ram-on in background video stream is used, right? I think video stream should be changed to audio only stream because of the video vs audio size in MBs.

Also I noticed that bottom navigation is not show up in new versions while video is playing. So its impossible to view virtual buttons (back, home, etc). It's not a big problem so new issue is not needed

ram-on commented 6 years ago

@avently To view the bottom navigation bar, just swipe from the very top (to bottom).

avently commented 6 years ago

@ram-on its working bad. Because swipe from bottom changes video position while controls are visible or shows a video description. Its ok to hide virtual buttons while video controls are hidden but its not ok to hide them while controls are visible

ram-on commented 6 years ago

@avently You need to swipe from the top (i.e. the location where time/date is normally displayed) downwards -- refer to https://i.imgur.com/N0Tlv1B.png

avently commented 6 years ago

@ram-on yes, I know about that "workaround". So you think your app should work like this?

ram-on commented 6 years ago

@avently That's how it is intended to be.

aspieln3r commented 4 years ago

it'd be great if a notification is shown when video is playing in the background

Davy49 commented 4 years ago

Hi, Thanks so much for the updated information ! David

hamishmb commented 2 years ago

So this can be closed now?