search

SkyTubeTeam / SkyTube

Copylefted libre / open source YouTube player for Android
GNU General Public License v3.0
2.37k stars 330 forks source link

Preferred languages UI tweaking #603

Open Gitoffthelawn opened 4 years ago

Gitoffthelawn commented 4 years ago

With SkyTube v2.967, videos are getting blocked by the Video Blocker, even with the following Video Blocker settings:

  1. Video blocker: Enabled
  2. Channel Filter Method: Blacklisting
  3. Channel Blacklist: Empty
  4. Preferred Region: Worldwide
  5. Preferred Language(s): None
  6. Views: Disabled
  7. Dislikes: Disabled
Gitoffthelawn commented 4 years ago

OK, I found the issue.

Setting "Preferred Language(s)" to None does not actually set it to none. It brings up the message "No preferred language selected. Setting ignored.". That message is a bit confusing, as whatever languages were previously set will continue to be set.

So I thought no languages were set, but in fact, some were set, thus causing the blocking (of all videos in other languages).

Maybe that message can be changed, and instead of dropping the user back to the Video Blocker settings page, it could send the user back to the Preferred Language(s) page.

Also, I think it would be good to allow not specifying any preferred languages in the Video Blocker. That way, as YouTube supports more languages, users who use the Video Blocker (but don't want to block by language), don't have to keep going back to "Preferred Language(s)" and click "Select All" to see videos using all languages.