search

SkyblockerMod / Skyblocker

Hypixel Skyblock fabric Mod for latest minecraft version
https://hysky.de
GNU Lesser General Public License v3.0
165 stars 79 forks source link

Item DFU doesn't fix up banner data #499

Open AzureAaron opened 7 months ago

AzureAaron commented 7 months ago

What happened?

The mod's DFU for items cannot fix up banner data resulting in items like the Totem of Corruption appearing as plain white banners without any patterns.

Screenshots

No response

Log output

No response

Minecraft Version

1.20.4

Skyblocker Version

skyblocker-1.16.0+1.20.4.jar

Additional context

No response

Julienraptor01 commented 7 months ago

DFU doesn't fix potions either Basically anything related to additional metadata in newer version is currently not datafixed

Like we have a convertItemId, we should probably designe a convertItemNBT that handle doing all NBTs transformations https://github.com/SkyblockerMod/Skyblocker/blob/0d6ae155fb799bcd0932cb6633f03bd73df2c9c3/src/main/java/de/hysky/skyblocker/skyblock/itemlist/ItemFixerUpper.java#L299 https://github.com/SkyblockerMod/Skyblocker/blob/0d6ae155fb799bcd0932cb6633f03bd73df2c9c3/src/main/java/de/hysky/skyblocker/skyblock/itemlist/ItemStackBuilder.java#L39

That's one of the improvements i had partially done on my 1.19.2 fork, so i can try to upstream theses changes I'll try to do it in about a week when my exam session finishes

AzureAaron commented 7 months ago

DFU doesn't fix potions either Basically anything related to additional metadata in newer version is currently not datafixed

Like we have a convertItemId, we should probably designe a convertItemNBT that handle doing all NBTs transformations

https://github.com/SkyblockerMod/Skyblocker/blob/0d6ae155fb799bcd0932cb6633f03bd73df2c9c3/src/main/java/de/hysky/skyblocker/skyblock/itemlist/ItemFixerUpper.java#L299

https://github.com/SkyblockerMod/Skyblocker/blob/0d6ae155fb799bcd0932cb6633f03bd73df2c9c3/src/main/java/de/hysky/skyblocker/skyblock/itemlist/ItemStackBuilder.java#L39

That's one of the improvements i had partially done on my 1.19.2 fork, so i can try to upstream theses changes I'll try to do it in about a week when my exam session finishes

I also wonder to an extent if it'd be possible to use Mojang's DFU for some of this stuff.

Julienraptor01 commented 7 months ago

DFU doesn't fix potions either Basically anything related to additional metadata in newer version is currently not datafixed

Like we have a convertItemId, we should probably designe a convertItemNBT that handle doing all NBTs transformations

https://github.com/SkyblockerMod/Skyblocker/blob/0d6ae155fb799bcd0932cb6633f03bd73df2c9c3/src/main/java/de/hysky/skyblocker/skyblock/itemlist/ItemFixerUpper.java#L299

https://github.com/SkyblockerMod/Skyblocker/blob/0d6ae155fb799bcd0932cb6633f03bd73df2c9c3/src/main/java/de/hysky/skyblocker/skyblock/itemlist/ItemStackBuilder.java#L39

That's one of the improvements i had partially done on my 1.19.2 fork, so i can try to upstream theses changes I'll try to do it in about a week when my exam session finishes

I also wonder to an extent if it'd be possible to use Mojang's DFU for some of this stuff.

Maybe ? That could be an idea to investigate Another thing we could investigate is setup up our own items repo with things already datafixed