search

SkyblockerMod / Skyblocker

Hypixel Skyblock fabric Mod for latest minecraft version
https://hysky.de
GNU Lesser General Public License v3.0
169 stars 79 forks source link

DungeonSecretWidget has wrong indexes for secrets and crypts #503

Closed Emirlol closed 7 months ago

Emirlol commented 8 months ago

What happened?

When class milestone 9 is reached, the discoveries section moves up by 1 (so the index is 1 lower). Currently the widget has the indexes for that situation and breaks if class milestone isn't 9 yet, showing discovery count in secrets count and secrets count in crypts count. To be specific:

Class milestone == 9 indexes (current)

Class milestone != 9 indexes

I couldn't think of a clean way to solve this, so I'm leaving this as an issue to whoever might want to tackle this issue.

Screenshots

No response

Log output

No response

Minecraft Version

1.20.4

Skyblocker Version

Seems to be wrong since the initial commit, so it doesn't matter

Additional context

No response

AzureAaron commented 8 months ago

Well it wasn't really wrong, Hypixel just added the class milestone thing and it was never updated.