SkyblockerMod / Skyblocker

Hypixel Skyblock fabric Mod for latest minecraft version
https://hysky.de
GNU Lesser General Public License v3.0
174 stars 84 forks source link

No Texture Bars #889

Open LordErelis opened 3 months ago

LordErelis commented 3 months ago

What happened?

When removing the custom health bar the other custom bars (mana, exp, defense) lose the colored part of the texture they just become gray

Screenshots

previewinconfig ingame

Log output

No response

Minecraft Version

1.21.0

Skyblocker Version

skyblocker-1.21.1+1.21.jar

Additional context

Im using the Skyblocker-Modpack and have not tested weather the bug is related to the modpack or the mod Edit: The problem does only appear when I play the Modpack

Julienraptor02 commented 3 months ago

This is a conflict with ImmediatlyFast sadly if the vanilla health bar render then the textures of the other bars break you could maybe avoid the issue by disabling HUD batching in IF but it give a massive perf boost the proper fix would be for us to report it to IF and then implement a proper fix

aiden-powers commented 3 months ago

I am attempting to re-create this issue in the modpack, but I don't see it happening.

image
LordErelis commented 3 months ago

Thats weired I could (and still can) reproduce it when deleting and reinstalling the Modpack Edit: Also for testing I made a modpack containing the same skyblock mods as well as iris, sodium and sodium extras - the bug did not appear there

aiden-powers commented 3 months ago

This may be a combination of very specific settings that cause this issue. If you install just Skyblocker (the mod) and ImmediatelyFast, does this issue still appear?

LordErelis commented 3 months ago

It does not

aiden-powers commented 3 months ago

Which settings allowed you to enable the text above the bars?

image

LordErelis commented 3 months ago

Just thinking: When you have a mod like fullbright installed and than change from installation for example 1.18.2 to 1.20 (any version) than the high gamma setting will still be applied despite not having the mod installed. So could it be possible that there is some render related setting beeing applied in a similar way causing the issue? Edit: could be complete nonsens but i don't see anything else that could cause the bug after fully deleting and reinstalling the modpack.

LordErelis commented 3 months ago

Which settings allowed you to enable the text above the bars?

image

Another Mod (i added it after the issue appeared) adding a health and mana bar to have working bars - was a "bad timed screenshot" Edit: for context the questioned mod https://modrinth.com/mod/sbt But again the problem appeared before i added the mod - I added the mod later as "compensation"

aiden-powers commented 2 months ago

This is a conflict with ImmediatlyFast sadly

if the vanilla health bar render then the textures of the other bars break

you could maybe avoid the issue by disabling HUD batching in IF but it give a massive perf boost

the proper fix would be for us to report it to IF and then implement a proper fix

It doesn't look like this is the issue, if it's causing the HUD to break, why not all of it? The background grey bar remains, making me think the mod failed to update/create the value of the colored bar.

My theory only applies though if the bar preview always assumes the full position, while creating the data dependent version upon applying the layout.

Julienraptor02 commented 2 months ago

It doesn't look like this is the issue, if it's causing the HUD to break, why not all of it? The background grey bar remains, making me think the mod failed to update/create the value of the colored bar.

It is the issue. Technically the HUD isn't breaking / is breaking entirely. The problem is not that the colored bar is not rendered, the problem is that it's getting rendered behind the grey bar. What's likely happening is that when vanilla hearts are rendered, IF detect it and decide to batch the HUD, breaking our bars due to how we are injected and how we do our rendering. the only fix is either that we use IF API to batch our HUD correctly, that we somehow change our injection and rendering code, that we get IF to fix this behavior or a combination of multiple / all of these possibilities.