Implement file upload without name test

Skycatch / node-box

Box API client for Node.JS

MIT License

21 stars 19 forks source link

Implement file upload without name test #12

Closed srt32 closed 9 years ago

srt32 commented 9 years ago

Adds a test for files.upload (without custom name).
Adds nock as a devDependency for testing.

I'd enjoy any feedback on the approach I took and would also be happy to add coverage to some of the other functions if we're happy with the general direction here.

Conversation started in https://github.com/Skycatch/node-box/pull/3#issuecomment-136026675

allisonfong commented 9 years ago

:+1:

adamhadani commented 9 years ago

:+1:

yuhunglin commented 9 years ago

:+1:

srt32 commented 9 years ago

Ping @lyaunzbe, curious about your thoughts.

lyaunzbe commented 9 years ago

LGTM. Thanks! You are more than welcome to add additional coverage for other functions, it is much appreciated!

srt32 commented 9 years ago

Great, thanks! @lyaunzbe what would you think about setting up CI (maybe using http://circleci.com/) for this repo?