search

Skycatch / node-box

Box API client for Node.JS
MIT License
21 stars 19 forks source link

Events #14

Open johncant opened 8 years ago

johncant commented 8 years ago

Added API calls for box.com long polling endpoints.

srt32 commented 8 years ago

Nice addition! Would you consider adding test coverage (maybe something similar to https://github.com/johncant/node-box/blob/events/test/index.js) and / or some updates to the limited documentation in the README for this new functionality?

johncant commented 8 years ago

Apologies, but I don't really see myself writing any tests for this functionality. I don't have enough time, only one of the other calls is tested, and also the fact that this library is broken in a much bigger way - it won't handle network errors, which will crash node. I'll submit another pull request to fix that soon. Also, I'll update the README.

srt32 commented 8 years ago

No apologies needed. Sounds like a reasonable plan. :). Happy new year! On Fri, Jan 1, 2016 at 07:39 John Cant notifications@github.com wrote:

Apologies, but I don't really see myself writing any tests for this functionality. I don't have enough time, only one of the other calls is tested, and also the fact that this library is broken in a much bigger way

  • it won't handle network errors, which will crash node. I'll submit another pull request to fix that soon. Also, I'll update the README.

— Reply to this email directly or view it on GitHub https://github.com/Skycatch/node-box/pull/14#issuecomment-168313415.