search

Skycoder42 / QHotkey

A global shortcut/hotkey for Desktop Qt-Applications
BSD 3-Clause "New" or "Revised" License
552 stars 162 forks source link

removed warning for wide range of GCC versions (5,6,7), fixes #9 #10

Closed Kolcha closed 6 years ago

Kolcha commented 6 years ago

removed macro which produces warning with GCC 5 or 6 and added simple comment instead of it (to disable warning produced by GCC 7) fixes #9

Skycoder42 commented 6 years ago

I recently discovered the Q_FALLTHROUGH macro. I was planning to use this one instead of the warning disablers, as that macro works for gcc7, clang, msvc, etc.

Could you add the macro in the line before the comment? Having both seems like a good solution to me

Kolcha commented 6 years ago

added. but notice, according to documentation, this macro available only since Qt 5.8. maybe it worth mentioning somewhere in your README

Skycoder42 commented 6 years ago

Thanks, I will keep that in mind