Skycoder42 / QHotkey

A global shortcut/hotkey for Desktop Qt-Applications
BSD 3-Clause "New" or "Revised" License
552 stars 162 forks source link

X11 Media Key Support #13

Closed aknobloch closed 6 years ago

aknobloch commented 6 years ago

Hey Skycoder,

I know this is not a very elegant solution and is basically a hacky workaround. But I'd really like to see support for media keys, and I don't want to ask without at least providing some sort of solution. XFree86 are extensions to the keysymdef.h file that X11 lib includes, and is shipped with most major distributions. The problem here was that Qt keys don't map (even 1:1) to these, which makes XStringToKeysym() fail. That X method does load the XF86keysym.h file, however so these are valid keys on all OSs that include these definitions.

If you'd be interested in extending support for media keys, I'd be happy to develop and test on X11 and Windows (don't have access to a Mac). I can employ similar solutions if you can't think of a better one, but I'd be happy to discuss better solutions as well. Thanks!

Skycoder42 commented 6 years ago

I'm totally fine with hacky solutions for the keycodes... (I mean, just look at the windows code). Generic conversion is fine as long as it works, but the more keys we can support, the better. Thanks for the PR.

If you'd be interested in extending support for media keys, I'd be happy to develop and test on X11 and Windows (don't have access to a Mac). I can employ similar solutions if you can't think of a better one, but I'd be happy to discuss better solutions as well. Thanks!

That would be awesome! I think the solution is fine, as there is no "universal generic solution" for keycodes. If you can find a solution for windows, that would be awesome.