Skycoder42 / QHotkey

A global shortcut/hotkey for Desktop Qt-Applications
BSD 3-Clause "New" or "Revised" License
552 stars 162 forks source link

Improve error messages #40

Closed Shatur closed 4 years ago

Shatur commented 4 years ago

Before:

QHotkey: Failed to register hotkey. Error: BadAccess (attempt to access private resource denied)
QHotkey: Failed to unregister hotkey. Error: BadAccess (attempt to access private resource denied)
QHotkey: Failed to register hotkey. Error: BadAccess (attempt to access private resource denied)
QHotkey: Failed to unregister hotkey. Error: BadAccess (attempt to access private resource denied)
QHotkey: Failed to register hotkey. Error: BadAccess (attempt to access private resource denied)

After:

QHotkey: "Failed to register Ctrl+Alt+E. Error: BadAccess (attempt to access private resource denied)"
QHotkey: "Failed to register Ctrl+Alt+S. Error: BadAccess (attempt to access private resource denied)"
QHotkey: "Failed to register Ctrl+Alt+G. Error: BadAccess (attempt to access private resource denied)"
QHotkey: "Failed to register Ctrl+Alt+F. Error: BadAccess (attempt to access private resource denied)"
QHotkey: "Failed to register Ctrl+Alt+C. Error: BadAccess (attempt to access private resource denied)"

Also users will be less confused (https://github.com/crow-translate/crow-translate/issues/149).

Shatur commented 4 years ago

@Skycoder42, could you draft a new minor release with this change?