Skycoder42 / QHotkey

A global shortcut/hotkey for Desktop Qt-Applications

BSD 3-Clause "New" or "Revised" License

548 stars 161 forks source link

Fix: Prevent crash on Wayland when using Qt 6 #97

Closed Cuperino closed 3 months ago

Cuperino commented 4 months ago

x11Interface is not guaranteed have been instantiated under a Wayland session, this led apps to be terminated by signal SIGSEGV (Address boundary error)

Cuperino commented 4 months ago

Qt mirrors need to be updated for CI to function. My code didn't cause those failures.

Shatur commented 4 months ago

Could you bump the install Qt action?

Shatur commented 3 months ago

Could you rebase to the latest master?

Cuperino commented 3 months ago

Done

Cuperino commented 3 months ago

96 solves the same issue as this PR does. I personally like this solution better, but i wrote it, so I'm biased.

dbermond commented 3 months ago

96 solves the same issue as this PR does. I personally like this solution better, but i wrote it, so I'm biased.

Your looks better, since it uses one less checking for nullptr.

Shatur commented 3 months ago

Thanks, merging then!