search

Skycoder42 / QHotkey

A global shortcut/hotkey for Desktop Qt-Applications
BSD 3-Clause "New" or "Revised" License
548 stars 161 forks source link

Bump Qt and CI script versions, fix macOS support, and drop support for qmake #98

Closed Cuperino closed 3 months ago

Cuperino commented 3 months ago

Bumping the Qt acquisition script should fix build errors in CI.

Cuperino commented 3 months ago

I've bumped the versions to the latest micro versions available. Nevertheless, the Qt 5s fail to build, with linker undefined symbol errors that occur after bumping jurplel/install-qt-action.

Shatur commented 3 months ago

Looks like on MacOS it tries to build it for ARM, but Qt binaries are for x86.

Cuperino commented 3 months ago

@Shatur I got CI fixed for all systems using CMake. I couldn't get the qmake build to work with Windows, I don't normally work on Windows and QMake is being phased out anyways, so I opted to remove those builds from CI in the end.

Feel free to re-add them and fix whatever issue is left. Here is the commit that got the closest to getting qmake to work everywhere: 57525e01402bd21c36225858147470861b80f720

Shatur commented 3 months ago

I'm on board with removing qmake. Could you remove the qmake file completely?

Cuperino commented 3 months ago

Done. All files pertaining qmake have been removed.

Shatur commented 3 months ago

Thank you!