search

Skydio / revup

Effortlessly create and manage pull requests without changing branches. Powers a stacked diffs workflow with python and git "plumbing" commands.
https://github.com/Skydio/revup
MIT License
310 stars 59 forks source link

Only raise in parse_topics when uploading #107

Closed jerry-skydio closed 1 year ago

jerry-skydio commented 1 year ago

amend will populate topics so that it can use topic names to locate commits. However in the case that there is format or usage error in the commit text, we don't want to raise at this point since it prevents amend from being used to fix it in the first place.

Topic: raise Reviewers: brian-k

jerry-skydio commented 1 year ago

Reviews in this chain: └https://github.com/Skydio/revup/pull/107 Only raise in parse_topics when uploading

jerry-skydio commented 1 year ago
# head base diff date summary
0 2f8de84c 932120e6 diff Apr 4 20:18 PM 2 files changed, 10 insertions(+), 5 deletions(-)
1 402e80a6 9a01d118 diff Apr 5 4:09 AM 1 file changed, 28 insertions(+), 11 deletions(-)
2 5b68e497 9a01d118 diff Apr 5 22:49 PM 0 files changed