search

Skydio / revup

Effortlessly create and manage pull requests without changing branches. Powers a stacked diffs workflow with python and git "plumbing" commands.
https://github.com/Skydio/revup
MIT License
310 stars 59 forks source link

Switch to async_lru for lru_cache() #112

Closed jerry-skydio closed 1 year ago

jerry-skydio commented 1 year ago

Turns out functools.lru_cache doesn't actually work for coroutines, it ends up caching the coroutine itself which is useless and crashes if called again.

Switch to async_lru, which provides a dropin replacement.

Topic: async_lru Reviewers: brian-k

jerry-skydio commented 1 year ago

Reviews in this chain: └https://github.com/Skydio/revup/pull/112 Switch to async_lru for lru_cache()

jerry-skydio commented 1 year ago
# head base diff date summary
0 19c25f29 caa2b08d diff Apr 13 13:58 PM 2 files changed, 3 insertions(+), 1 deletion(-)