search

Skydio / revup

Effortlessly create and manage pull requests without changing branches. Powers a stacked diffs workflow with python and git "plumbing" commands.
https://github.com/Skydio/revup
MIT License
310 stars 59 forks source link

Delete topic from list if skipping #113

Closed jerry-skydio closed 1 year ago

jerry-skydio commented 1 year ago

When skipping topics because they are not explicitly specified, make sure to remove them from self.topics (we also do this for self authored only). Otherwise they can result in errors down the line as self.topics is used for other checks.

Also don't delete the topic from the limit_topics list as that messes up checks in later iterations. Instead check against self.topics when printing out missing topics later.

Topic: topicsonly Reviewers: brian-k, aaron

jerry-skydio commented 1 year ago

Reviews in this chain: └https://github.com/Skydio/revup/pull/113 Delete topic from list if skipping

jerry-skydio commented 1 year ago
# head base diff date summary
0 0eb93d9a ed6935db diff Apr 13 16:11 PM 1 file changed, 1 insertion(+)
1 cba6b52a ed6935db diff Apr 13 18:20 PM 1 file changed, 2 insertions(+), 2 deletions(-)