search

Skydio / revup

Effortlessly create and manage pull requests without changing branches. Powers a stacked diffs workflow with python and git "plumbing" commands.
https://github.com/Skydio/revup
MIT License
310 stars 59 forks source link

Catch and warn on github timeouts #114

Closed jerry-skydio closed 1 year ago

jerry-skydio commented 1 year ago

Its pretty common for us to hit the 10s github timeout for very large graphql mutations. In pretty much all of these cases though, the actual changes in the request did go through, and a subsequent revup upload will show everything up to date.

To reflect this and make it nicer for users, catch any github exception that contains 'timeout' and turn it into a warning instead. This ensures that we show the topic list. If the user wishes, they can rerun the command to verify the changes were actually successful.

Topic: githubtimeout Reviewers: aaron, brian-k

jerry-skydio commented 1 year ago

Reviews in this chain: └https://github.com/Skydio/revup/pull/114 Catch and warn on github timeouts

jerry-skydio commented 1 year ago
# head base diff date summary
0 1a9feb29 92bd9efb diff Apr 13 19:17 PM 3 files changed, 26 insertions(+), 17 deletions(-)
1 7d701a07 7ca78675 diff Apr 18 19:20 PM 1 file changed, 7 insertions(+), 3 deletions(-)
2 9f73e92c 7ca78675 diff Apr 18 19:23 PM 1 file changed, 1 insertion(+), 1 deletion(-)