search

Skydio / revup

Effortlessly create and manage pull requests without changing branches. Powers a stacked diffs workflow with python and git "plumbing" commands.
https://github.com/Skydio/revup
MIT License
310 stars 59 forks source link

setup: Add missing transitive dependencies #124

Closed jerry-skydio closed 1 year ago

jerry-skydio commented 1 year ago

Most of these are actually dependencies of aiohttp but it seem like they're not declared there, causing some missing package errors for users.

I think if we declare them here it will fix this issue.

jerry-skydio commented 1 year ago

Reviews in this chain: └https://github.com/Skydio/revup/pull/124 setup: Add missing transitive dependencies

jerry-skydio commented 1 year ago
# head base diff date summary
0 af5fd55f 62448640 diff Jul 27 13:04 PM 1 file changed, 6 insertions(+)
aaron-skydio commented 1 year ago

Did you test this? Does seem like it has a good chance to fix, but I couldn't actually repro this today

jerry-skydio commented 1 year ago

yeah i ran make install locally and i see it installing all the new packages 

  Attempting uninstall: urllib3
    Found existing installation: urllib3 1.26.13
    Uninstalling urllib3-1.26.13:
      Successfully uninstalled urllib3-1.26.13
  Attempting uninstall: typing-extensions
    Found existing installation: typing_extensions 4.7.1
    Uninstalling typing_extensions-4.7.1:
      Successfully uninstalled typing_extensions-4.7.1
  Attempting uninstall: pygments
    Found existing installation: Pygments 2.15.1
    Uninstalling Pygments-2.15.1:
      Successfully uninstalled Pygments-2.15.1
  Attempting uninstall: multidict
    Found existing installation: multidict 6.0.4
    Uninstalling multidict-6.0.4:
      Successfully uninstalled multidict-6.0.4
  Attempting uninstall: mdurl
    Found existing installation: mdurl 0.1.2
    Uninstalling mdurl-0.1.2:
      Successfully uninstalled mdurl-0.1.2
  Attempting uninstall: idna
    Found existing installation: idna 3.4
    Uninstalling idna-3.4:
      Successfully uninstalled idna-3.4
  Attempting uninstall: frozenlist
    Found existing installation: frozenlist 1.4.0
    Uninstalling frozenlist-1.4.0:
      Successfully uninstalled frozenlist-1.4.0
  Attempting uninstall: charset-normalizer
    Found existing installation: charset-normalizer 3.2.0
    Uninstalling charset-normalizer-3.2.0:
      Successfully uninstalled charset-normalizer-3.2.0
  Attempting uninstall: attrs
    Found existing installation: attrs 23.1.0
    Uninstalling attrs-23.1.0:
      Successfully uninstalled attrs-23.1.0
  Attempting uninstall: async-timeout
    Found existing installation: async-timeout 4.0.2
    Uninstalling async-timeout-4.0.2:
      Successfully uninstalled async-timeout-4.0.2
  Attempting uninstall: yarl
    Found existing installation: yarl 1.9.2
    Uninstalling yarl-1.9.2:
      Successfully uninstalled yarl-1.9.2
  Attempting uninstall: requests
    Found existing installation: requests 2.28.1
    Uninstalling requests-2.28.1:
      Successfully uninstalled requests-2.28.1
  Attempting uninstall: markdown-it-py
    Found existing installation: markdown-it-py 3.0.0
    Uninstalling markdown-it-py-3.0.0:
      Successfully uninstalled markdown-it-py-3.0.0
  Attempting uninstall: async-lru
    Found existing installation: async-lru 2.0.4
    Uninstalling async-lru-2.0.4:
      Successfully uninstalled async-lru-2.0.4
  Attempting uninstall: aiosignal
    Found existing installation: aiosignal 1.3.1
    Uninstalling aiosignal-1.3.1:
      Successfully uninstalled aiosignal-1.3.1
  Attempting uninstall: rich
    Found existing installation: rich 13.4.2
    Uninstalling rich-13.4.2:
      Successfully uninstalled rich-13.4.2
  Attempting uninstall: aiohttp
    Found existing installation: aiohttp 3.8.5
    Uninstalling aiohttp-3.8.5:
      Successfully uninstalled aiohttp-3.8.5