Skydio / revup

Effortlessly create and manage pull requests without changing branches. Powers a stacked diffs workflow with python and git "plumbing" commands.
https://github.com/Skydio/revup
MIT License
310 stars 59 forks source link

feat: Store credentials over Git credential manager #129

Closed gabyx closed 8 months ago

gabyx commented 9 months ago

Is your feature request related to a problem? Please describe. Its not wise to store credentials on the disk, and I am unsure about if revup already has a feature which disables this. Yesterday @elia-kaufmann-skydio showed me the tool and I think its a valuable tool for avoiding branch switches etc, if you know what you are doing...

Describe the solution you'd like The tool should use git credential approve to store the credential and git credential fill to get it back to make API requests. https://git-scm.com/docs/git-credential

echo -e "username=bla-revup\npassword=<token>\nprotocol=https\nhost=github.com\n" | git credential approve

and then you simply request it with echo -e "username=bla-revup\nprotocol=https\nhost=github.com\n" | git credential fill I think storing it directly over Git's own manager is better. Just make a designated username and thats it. No store on the drive etc...

Describe alternatives you've considered None.