search

Skydio / revup

Effortlessly create and manage pull requests without changing branches. Powers a stacked diffs workflow with python and git "plumbing" commands.
https://github.com/Skydio/revup
MIT License
310 stars 59 forks source link

Fix priority of repo config vs home config #130

Closed anguslees closed 8 months ago

anguslees commented 9 months ago

Reorder configparser.read calls to ensure <repo>/.revupconfig overrides ~/.revupconfig

jerry-skydio commented 8 months ago

(from the doc)

Revup loads options in this order:

   · The program has built in defaults that are given in the manual.

   · Repo configs take precedence over the above.

   · User configs take precedence over the above.

   · Command line flags specified by the user take highest precedence.

Seems like the current behavior is as intended -- the thinking is that the user should have the highest level control and should be able to configure overrides to repo settings (which are presumably committed into the repo and could have been set by anyone). This doesn't mean that the current behavior fills all usecases though, there are some cases where user might want to configure their own per-repo settings, which we don't support yet but would probably live in .git/.revupconfig. In any case if something like this is your goal I recommend filing an issue to make that need explicit.