search

Skydio / revup

Effortlessly create and manage pull requests without changing branches. Powers a stacked diffs workflow with python and git "plumbing" commands.
https://github.com/Skydio/revup
MIT License
309 stars 59 forks source link

amend: respect git config commit.cleanup #151

Closed jerry-skydio closed 6 months ago

jerry-skydio commented 6 months ago

Git commit has several configuration options for how to strip comment lines out of the commit text. We generally want to support these because they affect whether we throw away prefixed lines that could be important text to the user.

"strip" is just the default way we've been doing it, so refactor to also support "scissors" which has a different comment and removal method. "whitespace" and "verbatim" are simpler strategies that we can support as well, but get no additional comment

Fixes: #148

jerry-skydio commented 6 months ago

Reviews in this chain: └https://github.com/Skydio/revup/pull/151 amend: respect git config commit.cleanup 　└https://github.com/Skydio/revup/pull/152 amend: respect core.commentChar

jerry-skydio commented 6 months ago
# head base diff date summary
0 a3fc421e d7f409ca diff Mar 11 19:23 PM 1 file changed, 33 insertions(+), 8 deletions(-)
1 1c175034 d7f409ca diff Mar 11 19:39 PM 1 file changed, 5 insertions(+), 1 deletion(-)
2 ef0f540b d7f409ca diff Mar 11 19:41 PM 0 files changed
3 417a57fc d7f409ca diff Mar 11 19:52 PM 1 file changed, 1 insertion(+), 1 deletion(-)
4 56a4716c faff673f diff Mar 12 11:03 AM 1 file changed, 7 insertions(+), 2 deletions(-)