amend: Correctly strip comments with no trailing newline

Skydio / revup

Effortlessly create and manage pull requests without changing branches. Powers a stacked diffs workflow with python and git "plumbing" commands.

https://github.com/Skydio/revup

MIT License

309 stars 59 forks source link

amend: Correctly strip comments with no trailing newline #171

Closed brian-kubisiak-skydio closed 5 months ago

brian-kubisiak-skydio commented 5 months ago

Revup's default COMMIT_EDITMSG does not have a trailing newline; as a result, the regex used for matching comment lines when cleanup_type is 'strip' will not match the last line in the message and can leave a trailing comment line. Fix this by making the trailing newline optional in the regex.

Fixes: 24012d1 ("amend: respect git config commit.cleanup") Signed-off-by: Brian Kubisiak brian@kubisiak.com

brian-kubisiak-skydio commented 5 months ago

Reviews in this chain: └https://github.com/Skydio/revup/pull/171 amend: Correctly strip comments with no trailing newline

brian-kubisiak-skydio commented 5 months ago

#	head	base	diff	date	summary
0	8d25f04d	d29851a6	diff	Mar 18 10:28 AM	1 file changed, 1 insertion(+), 1 deletion(-)