When using Branches: and PR is merged, rebase detection can fail and cause pr to be re-created

Skydio / revup

Effortlessly create and manage pull requests without changing branches. Powers a stacked diffs workflow with python and git "plumbing" commands.

https://github.com/Skydio/revup

MIT License

309 stars 59 forks source link

When using Branches: and PR is merged, rebase detection can fail and cause pr to be re-created #174

Open jerry-skydio opened 5 months ago

jerry-skydio commented 5 months ago

Upload change from branch A but target other branch B with Branches:. When change merges and you fetch B again, revup continues to upload the PR to B, does the cherry-pick, finds that it succeeds and produces an empty commit, then finds the patch-id of the empty commit, compares against original, and mistakenly finds that it changed and thus re-uploads.

jerry-skydio commented 5 months ago

this seems to only happen for relative chains that get targeted to a different branch. possibly only when the relative change forces a push of the parent