search

Skydio / revup

Effortlessly create and manage pull requests without changing branches. Powers a stacked diffs workflow with python and git "plumbing" commands.
https://github.com/Skydio/revup
MIT License
309 stars 59 forks source link

credential: Remove leading slash before path #175

Closed jerry-skydio closed 5 months ago

jerry-skydio commented 5 months ago

The slash is incorrect according to https://github.com/Skydio/revup/pull/131#discussion_r1548896688

"The leading "/" here is incorrect btw, and fails for credential helpers that do naive string matching on URL path 😞. It should be just path=f"{fork_info.owner}/{fork_info.name}.git""

jerry-skydio commented 5 months ago

Reviews in this chain: └https://github.com/Skydio/revup/pull/175 credential: Remove leading slash before path 　└https://github.com/Skydio/revup/pull/176 git: Properly redact oauth from git credential

jerry-skydio commented 5 months ago
# head base diff date summary
0 41a3467c c7b873f4 diff Apr 3 11:40 AM 2 files changed, 2 insertions(+), 1 deletion(-)
1 125ba9cc c7b873f4 diff Apr 3 12:15 PM 0 files changed