search

Skydio / revup

Effortlessly create and manage pull requests without changing branches. Powers a stacked diffs workflow with python and git "plumbing" commands.
https://github.com/Skydio/revup
MIT License
317 stars 67 forks source link

Fix mistaken 'continue' in rebase logic #47

Closed jerry-skydio closed 2 years ago

jerry-skydio commented 2 years ago

Somehow I confused 'continue' for 'pass'.

This was causing the push marking loop logic to get totally skipped, resulting in crashes and cases where commit ids could not be found in depending reviews.

Topic: mistake Reviewers: brian-k, greg Fixes: #6

jerry-skydio commented 2 years ago

Reviews in this chain: └https://github.com/Skydio/revup/pull/47 Fix mistaken 'continue' in rebase logic

jerry-skydio commented 2 years ago
# head base diff date summary
0 39c7eb7e b8abc845 diff Sep 16 3:21 PM 1 file changed, 1 insertion(+), 1 deletion(-)
1 df44435c b8abc845 diff Sep 16 3:43 PM 0 files changed