Skydio / revup

Effortlessly create and manage pull requests without changing branches. Powers a stacked diffs workflow with python and git "plumbing" commands.
https://github.com/Skydio/revup
MIT License
310 stars 61 forks source link

Fix warnings and errors with setup #49

Closed jerry-skydio closed 2 years ago

jerry-skydio commented 2 years ago

Fix man files not being included.

Fix deprecation warnings related to licenses field and packages.

Fix git revision not being found correctly because setup.py is executed in a tmp directory. Instead find the revision in the makefile and pass it into setup.

Topic: fixes Reviewers: brian-k, aaron

jerry-skydio commented 2 years ago

Reviews in this chain: └https://github.com/Skydio/revup/pull/49 Fix warnings and errors with setup

jerry-skydio commented 2 years ago
# head base diff date summary
0 157725ea 07b7b91f diff Sep 19 1:31 PM 3 files changed, 16 insertions(+), 30 deletions(-)
1 fe83ea47 07b7b91f diff Sep 19 1:32 PM 1 file changed, 1 insertion(+)
2 e7b3968b 07b7b91f diff Sep 19 1:35 PM 1 file changed, 1 insertion(+), 1 deletion(-)
3 95ef0588 07b7b91f diff Sep 19 1:46 PM 1 file changed, 1 insertion(+)
4 ad2876de 07b7b91f diff Sep 19 1:49 PM 1 file changed, 1 insertion(+), 2 deletions(-)
5 5deae3bb 07b7b91f diff Sep 19 1:51 PM 1 file changed, 1 insertion(+), 1 deletion(-)
6 0f25d999 07b7b91f diff Sep 19 1:52 PM 1 file changed, 1 deletion(-)
aaron-skydio commented 2 years ago

GitHub Actions, nice - I guess I'll wait to review until that's passing?

jerry-skydio commented 2 years ago

I have no idea why but when I try to make this patch

index 8e637fd..bbd693f 100644
--- a/setup.cfg
+++ b/setup.cfg
@@ -34,10 +34,11 @@ classifiers =
 [options]
 package_dir =
      = .
 packages =
     revup
+    revup/man1
 python_requires = >=3.8
 install_requires =
     aiohttp
     rich
 setup_requires = 

despite everything working locally, CI fails at the pip install . step with "package directory 'revup/man1' does not exist". I guess i'll put this off since it was only handling a warning anyway