search

Skydio / revup

Effortlessly create and manage pull requests without changing branches. Powers a stacked diffs workflow with python and git "plumbing" commands.
https://github.com/Skydio/revup
MIT License
310 stars 61 forks source link

git: Remove --binary from diff args #67

Closed jerry-skydio closed 1 year ago

jerry-skydio commented 1 year ago

We don't need a binary patch in order to apply because we just use object ids for 3way.

Git patch-id is broken for all binary diffs, although its slightly less broken if there is no patch -- it just produces the same patch-id rather than breaking parsing for the rest of the commit.

Topic: patchid Reviewers: brian-k

jerry-skydio commented 1 year ago

Reviews in this chain: └https://github.com/Skydio/revup/pull/67 git: Remove --binary from diff args

jerry-skydio commented 1 year ago
# head base diff date summary
0 c1bdab1a aa41c582 diff Oct 10 11:21 AM 1 file changed, 1 deletion(-)