search

Skydio / revup

Effortlessly create and manage pull requests without changing branches. Powers a stacked diffs workflow with python and git "plumbing" commands.
https://github.com/Skydio/revup
MIT License
310 stars 61 forks source link

patchsets: Make virtual diff target with shared history #81

Closed jerry-skydio closed 1 year ago

jerry-skydio commented 1 year ago

Previously we just made the first virtual diff target with no parent resulting in a branch with no shared history with any other branch. Strictly this shouldn't matter as we only use the branch for diffs, but we've seen a few cases where pushing this branch is specifically causing git push to take an incredibly long time. I don't have a great way to explain this as the virtual diff target should only be pushing the tree itself, all blobs within it reuse blobs that were already present in the repo.

Try to create the target with a shared history from an arbitrary commit to see if this resolves the issues we see.

Topic: vritdiff Reviewers: brian-k

jerry-skydio commented 1 year ago

Reviews in this chain: └https://github.com/Skydio/revup/pull/81 patchsets: Make virtual diff target with shared history

jerry-skydio commented 1 year ago
# head base diff date summary
0 e281c023 311ff10d diff Oct 24 17:49 PM 1 file changed, 2 insertions(+)
1 a3be2bdb 311ff10d diff Oct 24 17:50 PM 1 file changed, 1 insertion(+), 1 deletion(-)