search

SkygearIO / features

Feature Tracking Repo for Skygear
Apache License 2.0
3 stars 12 forks source link

Auth UI #425

Closed louischan-oursky closed 4 years ago

louischan-oursky commented 4 years ago

ref #370

carmenlau commented 4 years ago

@chpapa Can you review the whole documents when have time? We are still updating but should be some minor comments which won't affect the main flow. Would like to ensure we don't have big problem, and we started implementing already.

chpapa commented 4 years ago

@carmenlau sorry I am very busy these few days (like 1am most days) for business work... I probably don't have 3 hours to sit down and read things bit by bit.

Do you want to say have a 30 mins walk through with me tomorrow (11 Mar)? And see if @kiootic and @louischan would like to join?

carmenlau commented 4 years ago

We need to add a logout function for user who used authui. We cannot use the same logout function, since the implementation is totally different. We have 2 ideas,

  1. auth ui and auth api are 2 different packages.

  2. auth ui and auth api are in different namespace. e.g.

    auth ui functions:

    skygear.auth.startAuthorization
skygear.auth.finishAuthorization
skygear.auth.logout

    auth api functions:

    skygear.classicAuth.login
skygear.classicAuth.signup
skygear.classicAuth.logout

We had a discussion and due to time being, we will pick approach 2 first. We will move auth ui related functions in a new namespace authui. We can discuss and decide in production meeting.

@louischan-oursky @kiootic @chpapa @keithtkl

chpapa commented 4 years ago

@carmenlau I think the answer depends on if developer will use the auth api functions with ui a lot? Keep 2 packages will make it simpler for people who only use auth ui or auth api, less distraction. I don't have a good answer now... so maybe just go with the easier solution first.

louischan-oursky commented 4 years ago

I added a commit to specify how do the developer can configure country calling codes.