Replace update-version task with release-commit

[rickmak]

Updated

On 5 January 2018 at 11:35, Kwok-kuen Cheung notifications@github.com wrote:

@cheungpat requested changes on this pull request.

In Makefile https://github.com/SkygearIO/skygear-SDK-iOS/pull/167#discussion_r159802406 :

@@ -12,10 +12,9 @@ endif vendor: cd Example; pod install

-.PHONY: update-version -update-version:

• sed -i "" "s/(s.version[^=]=[^\"]\")[^\"]*/\1$(VERSION)/" SKYKit.podspec
• sed -i "" "s/#define SKY_VERSION @\".*\"/#define SKY_VERSION @\"$(VERSION)\"/" Pod/Classes/SKYKit+version.h +.PHONY: release-commit

let’s keep update-version?

In scripts/release-commit.sh https://github.com/SkygearIO/skygear-SDK-iOS/pull/167#discussion_r159802576 :

@@ -0,0 +1,26 @@ +if [ -z "$SKYGEAR_VERSION" ]; then

need #!/bin/sh -e here

In scripts/release-commit.sh https://github.com/SkygearIO/skygear-SDK-iOS/pull/167#discussion_r159802596 :

+if [ -z "$SKYGEAR_VERSION" ]; then

• &2 echo "SKYGEAR_VERSION is required."

• exit 1 +fi +if [ -z "$GITHUB_TOKEN" ]; then

• &2 echo "GITHUB_TOKEN is required."

• exit 1 +fi +if [ -z "$KEY_ID" ]; then

• &2 echo "KEY_ID is required."

• exit 1 +fi +if [ -e "new-release" ]; then
• echo "Making release commit and github release..." +else
• echo "file 'new-release' is required."

need to add >&2 here

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/SkygearIO/skygear-SDK-iOS/pull/167#pullrequestreview-86813820, or mute the thread https://github.com/notifications/unsubscribe-auth/AAD01epSILquH-s3_4qcGeYIzug00dQHks5tHZh9gaJpZM4RTCGN .

-- Rick Mak | Software Engineer | CC81327D Oursky.com | rickmak@oursky.com | 852-96205080