search

SkygearIO / skygear-SDK-iOS

Skygear SDK for iOS
https://skygear.io
Other
10 stars 28 forks source link

Reset password bug fix #196

Closed howawong closed 6 years ago

howawong commented 6 years ago

Connects #183

cheungpat commented 6 years ago
screen shot 2018-03-22 at 2 46 37 pm

I am okay with the changes but it seems the UI doesn’t look right in iPhone X, do you have time to fix this?

howawong commented 6 years ago

@cheungpat hmmm, I did not test with iPhone X simulator, let me just move the UI down a little bit.

cheungpat commented 6 years ago

@howawong would be better if you could fix the auto layout constraint, more future proof : )

cheungpat commented 6 years ago

@howawong I just checked out 708bd29 and it is missing the fix the safe area constraint : )

While you are at it, can you make the label for Email and User ID not scrollable? Thanks.