Use server-based default ACL

SkygearIO / skygear-SDK-iOS

Skygear SDK for iOS

https://skygear.io

Other

10 stars 28 forks source link

Use server-based default ACL #83

Closed b123400 closed 7 years ago

b123400 commented 7 years ago

connect https://github.com/SkygearIO/skygear-server/issues/309

oursky-travis commented 7 years ago

@b123400, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ben181231, @cheungpat and @limouren to be potential reviewers.

cheungpat commented 7 years ago

@b123400 I just want to let you know that the PR needs changes because of lint check errors.

b123400 commented 7 years ago

This is interesting, I didn't edit any swift file and swiftlint's failing

cheungpat commented 7 years ago

This is interesting, I didn't edit any swift file and swiftlint's failing

If this happens, this is usually caused by updated swiftlint version which might have additional checks for swift code. To verify that this happened. Trigger a rebuild on the master branch at travis and then make additional pull request to fix the lint errors. Then rebase this pull request.

cheungpat commented 7 years ago

@b123400 Would be great if you could fix the lint on the master branch first.

b123400 commented 7 years ago

OK, I guess it will take some time

cheungpat commented 7 years ago

I will merge this pull request after skygeario/skygear-server#329 is merged.