SkygearIO / skygear-doc

[Deprecated] Doc site generator for all the platform guides of Skygear; Content are here: https://github.com/SkygearIO/guides/tree/v1
https://docs.skygear.io/
MIT License
4 stars 19 forks source link

add demo, forum and slack to the header #574

Closed tensiuyan closed 6 years ago

tensiuyan commented 6 years ago

To improve the discoverability of our demos and support, I have added 'Demo', 'Forum' and 'Slack' to the header. To make things simple, I simply remove all the icons in front of the nav items.

I have updated part of the codes, but I am not sure if the implementation is okay. The major worry I have is about the removal of "href='#'. I have removed href="#" because I think it is not working. I guess originally we want the page to go to the top when users click on the active nav item. However it is currently blocked by the header. If we are to do it we need make it go back to the top of the component instead of the page. Just my two cents tho, please let me know if you want me to put the href="#" back. 🙇‍♀️🙇‍♀️🙇‍♀️🙇‍♀️