search

Skyl3lazer / giffyglyph-monster-maker-continued

A D&D 5e monster maker module for the Foundry VTT. Build new monsters with level-appropriate, balanced stats in seconds. This is a fork which has been updated to GGMM PDF v3, Foundry v10+11, and dnd5e 2.1+3.1.
6 stars 1 forks source link

When trying to add a new trait the Monster Sheet throws an error, Trait Sheet doesn't appear #44

Closed narayb closed 5 months ago

narayb commented 5 months ago

Just updated from the previous version.

image

Tested in a blank 5e world, with no other modules aside from libwrapper activated.

Skyl3lazer commented 5 months ago

@Orlando That is a separate issue, #36, which is fixed if you switch to dev.

@nayarb I'm out of town until the end of this month unfortunately so the main issue in this ticket will persist until then. It's likely due to concentration flags that were added in dnd3 - I fixed a bug in dev that may solve it, try using the dev version and seeing if it fixes it.

On Mon, Apr 15, 2024, 3:01 AM Orlando Fernandez @.***> wrote:

I'm getting a similar result with different errors in an established world before and after deactivating every module except this one. Yet no error in a different testing world. image.png (view on web) https://github.com/Skyl3lazer/giffyglyph-monster-maker-continued/assets/2471365/f452729c-5de0-434e-9a17-2b01ec15c479

— Reply to this email directly, view it on GitHub https://github.com/Skyl3lazer/giffyglyph-monster-maker-continued/issues/44#issuecomment-2054258474, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABQYWEWNGVT7O5TYHELRCRDY5MRFDAVCNFSM6AAAAABGGFBYQ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJUGI2TQNBXGQ . You are receiving this because you are subscribed to this thread.Message ID: <Skyl3lazer/giffyglyph-monster-maker-continued/issues/44/2054258474@ github.com>

narayb commented 5 months ago

I see. I'll give the Dev version a spin later this week, will report back!

narayb commented 5 months ago

image I experience the same errors when using the dev build. Neither actions nor traits can be created.

Skyl3lazer commented 5 months ago

Ah, I see the issue. I'm checking for foundry version being up to date there rather than DND5e version being up to date. If you're comfortable with code and need a fix you can change gmmItem.js, deleting lines 185, 186, 187, and 189 (leaving 188). I will push a fix for this in the next version, but as stated it'll be a week or two before I can.

narayb commented 5 months ago

Np man, I'll just revert to prev version for my game on Sunday. Thanks for all your hard work and the quick responses!

Skyl3lazer commented 5 months ago

Fixed on dev in f44f1fdaf868b65d873bb9e0c90e7683d344a9dd