search

SkylerPIlot / Barbarians-Assault-Personal-Bests

BSD 2-Clause "Simplified" License
1 stars 2 forks source link

Append "(new personal best)" to round time message when new pb achieved #5

Open equirs opened 1 year ago

equirs commented 1 year ago

Title, just a thought to make pbs more visible and more like the official boss pbs (I have no idea whether this is feasible)

SkylerPIlot commented 1 year ago

The plugin doesn't currently announce wave end time, but would be easy to implement announcing the wave end time. Might be confusing having Ba Minigame + This Plugin + Base runelite Plugin announcing the wave time.

Might be good to look into integrating this feature(Pbs) into Ba Minigame or reflecting Ba Minigame's methods to only announce one round time

equirs commented 1 year ago

Integrating into ba-minigame might not be necessary if we can intercept and modify the message it spits out (same for other plugins that announce round time). There are people out there who have multiple plugins enabled that print different times, but maybe it's not worth accounting for them: could just append it to the first one or all of them, doesn't really matter.

I've also realized since filing this that the plugin uses its own timer, which might not match with the outputted times from other plugins. Not really sure what you'd want to do if inconsistencies happen there (e.g., user sees a new pb as reported by ba-minigame but the pbs plugin doesn't pick that up).

Also occurred to me that differentiating between role pbs and overall pbs in the message could be done, too