search

SkylineSpartabots / SpartaSite

This repository holds the full source code for The Spartabots website (SpartaSite)
https://spartasite.gam3rr.me
4 stars 7 forks source link

[ENHANCEMENT] (Not of Priority) Add Dark Mode #15

Closed Gam3rrXD closed 3 months ago

Gam3rrXD commented 3 months ago

Many people hate light mode, as do i, this is why Dark Mode should be an option, this is primarily CSS tweaks, very minor JS. The idea is to have a toggle which is either a button or a switch that switches between light and dark modes, to store current status set up a cookie or browser cache.

mohit-bhandari45 commented 3 months ago

I want to work on this issue under gssoc24 Just add the label of gssoc24 to it Assign it to me

Gam3rrXD commented 3 months ago

done

Gam3rrXD commented 3 months ago

@mohit-bhandari45 when can this be worked on?

mohit-bhandari45 commented 3 months ago

Tomorrow I will make a PR

Gam3rrXD commented 3 months ago

@mohit-bhandari45 sounds good please let me know once pr is submitted

mohit-bhandari45 commented 3 months ago

I want to ask, are you in gssoc 24?

Gam3rrXD commented 3 months ago

I want to ask, are you in gssoc 24?

I do not believe we are

mohit-bhandari45 commented 3 months ago

Ok no problem But I think you can still add "gssoc24" and "level2" labels to it

Gam3rrXD commented 3 months ago

to the issue?

mohit-bhandari45 commented 3 months ago

Yup

mohit-bhandari45 commented 3 months ago

It's your choice btw, not necessary

Gam3rrXD commented 3 months ago

yea i gottchu doin rn

mohit-bhandari45 commented 3 months ago

Ok ok perfect

Gam3rrXD commented 3 months ago

done, let me know once pr created

mohit-bhandari45 commented 3 months ago

Are these cards looking good in dark mode? image image

Gam3rrXD commented 3 months ago

Are these cards looking good in dark mode? image image

They look ok, I'd also try the black #1f1f1f. Also, can you round the cards a slight bit so it isn't sharp corners. One more thing is there needs to be the toggle, for the toggle I'd like for it to float on the bottom right throughout the site. Thanks!

mohit-bhandari45 commented 3 months ago

Hey I have done the home section

Just tell me is the background color where there are cards is good or what. I not you can give me the hax codes of you color theme image

This is the second preview one:- image

Which one is looking good

Gam3rrXD commented 3 months ago

2nd one looks the best, lets go with that one

mohit-bhandari45 commented 3 months ago

I have created a pr, you can check

Gam3rrXD commented 3 months ago

Perfect, Thank you @mohit-bhandari45, i was wondering if you were able to push the same changes to these files, they are not currently being used but will setup in the near future. "./pages/ComingSoon" "./pages/Login" "./pages/NotFound" "./pages/OurTeam" "./pages/HistoryPage" "./pages/Purchase" "./pages/Software"

mohit-bhandari45 commented 3 months ago

Hey bro can we connect? This is y linkedin: https://www.linkedin.com/in/mohit-bhandari-9940542a0/

mohit-bhandari45 commented 3 months ago

Perfect, Thank you @mohit-bhandari45, i was wondering if you were able to push the same changes to these files, they are not currently being used but will setup in the near future. "./pages/ComingSoon" "./pages/Login" "./pages/NotFound" "./pages/OurTeam" "./pages/HistoryPage" "./pages/Purchase" "./pages/Software"

Sure!

Gam3rrXD commented 3 months ago

Hey bro can we connect? This is y linkedin: https://www.linkedin.com/in/mohit-bhandari-9940542a0/

Perfect, Thank you @mohit-bhandari45, i was wondering if you were able to push the same changes to these files, they are not currently being used but will setup in the near future. "./pages/ComingSoon" "./pages/Login" "./pages/NotFound" "./pages/OurTeam" "./pages/HistoryPage" "./pages/Purchase" "./pages/Software"

Sure!

Connected! and thank you so much

mohit-bhandari45 commented 3 months ago

Hey bro can we connect? This is y linkedin: https://www.linkedin.com/in/mohit-bhandari-9940542a0/

Perfect, Thank you @mohit-bhandari45, i was wondering if you were able to push the same changes to these files, they are not currently being used but will setup in the near future. "./pages/ComingSoon" "./pages/Login" "./pages/NotFound" "./pages/OurTeam" "./pages/HistoryPage" "./pages/Purchase" "./pages/Software"

Sure!

Connected! and thank you so much

Perfect!

Gam3rrXD commented 3 months ago

Some issues i have noticed on the current dark mode setup are as follows:

image image

mohit-bhandari45 commented 3 months ago

Yeah sure for mobile screen, I can work upon it. Do are you making a separate issue for it or work on it right here?

Gam3rrXD commented 3 months ago

you can work on it right here it should be fine

mohit-bhandari45 commented 3 months ago

and bro the second, issue is bcoz, the cards are different for mobile view, I didn't know it. I will fix it

mohit-bhandari45 commented 3 months ago

bro created a pr, you can check

Gam3rrXD commented 3 months ago

thanks for the pr!