Closed Gam3rrXD closed 3 months ago
I want to work on this issue under gssoc24 Just add the label of gssoc24 to it Assign it to me
done
@mohit-bhandari45 when can this be worked on?
Tomorrow I will make a PR
@mohit-bhandari45 sounds good please let me know once pr is submitted
I want to ask, are you in gssoc 24?
I want to ask, are you in gssoc 24?
I do not believe we are
Ok no problem But I think you can still add "gssoc24" and "level2" labels to it
to the issue?
Yup
It's your choice btw, not necessary
yea i gottchu doin rn
Ok ok perfect
done, let me know once pr created
Are these cards looking good in dark mode?
Are these cards looking good in dark mode?
![]()
They look ok, I'd also try the black #1f1f1f. Also, can you round the cards a slight bit so it isn't sharp corners. One more thing is there needs to be the toggle, for the toggle I'd like for it to float on the bottom right throughout the site. Thanks!
Hey I have done the home section
Just tell me is the background color where there are cards is good or what.
I not you can give me the hax codes of you color theme
This is the second preview one:-
Which one is looking good
2nd one looks the best, lets go with that one
I have created a pr, you can check
Perfect, Thank you @mohit-bhandari45, i was wondering if you were able to push the same changes to these files, they are not currently being used but will setup in the near future. "./pages/ComingSoon" "./pages/Login" "./pages/NotFound" "./pages/OurTeam" "./pages/HistoryPage" "./pages/Purchase" "./pages/Software"
Hey bro can we connect? This is y linkedin: https://www.linkedin.com/in/mohit-bhandari-9940542a0/
Perfect, Thank you @mohit-bhandari45, i was wondering if you were able to push the same changes to these files, they are not currently being used but will setup in the near future. "./pages/ComingSoon" "./pages/Login" "./pages/NotFound" "./pages/OurTeam" "./pages/HistoryPage" "./pages/Purchase" "./pages/Software"
Sure!
Hey bro can we connect? This is y linkedin: https://www.linkedin.com/in/mohit-bhandari-9940542a0/
Perfect, Thank you @mohit-bhandari45, i was wondering if you were able to push the same changes to these files, they are not currently being used but will setup in the near future. "./pages/ComingSoon" "./pages/Login" "./pages/NotFound" "./pages/OurTeam" "./pages/HistoryPage" "./pages/Purchase" "./pages/Software"
Sure!
Connected! and thank you so much
Hey bro can we connect? This is y linkedin: https://www.linkedin.com/in/mohit-bhandari-9940542a0/
Perfect, Thank you @mohit-bhandari45, i was wondering if you were able to push the same changes to these files, they are not currently being used but will setup in the near future. "./pages/ComingSoon" "./pages/Login" "./pages/NotFound" "./pages/OurTeam" "./pages/HistoryPage" "./pages/Purchase" "./pages/Software"
Sure!
Connected! and thank you so much
Perfect!
Some issues i have noticed on the current dark mode setup are as follows:
Yeah sure for mobile screen, I can work upon it. Do are you making a separate issue for it or work on it right here?
you can work on it right here it should be fine
and bro the second, issue is bcoz, the cards are different for mobile view, I didn't know it. I will fix it
bro created a pr, you can check
thanks for the pr!
Many people hate light mode, as do i, this is why Dark Mode should be an option, this is primarily CSS tweaks, very minor JS. The idea is to have a toggle which is either a button or a switch that switches between light and dark modes, to store current status set up a cookie or browser cache.