search

SkylineSpartabots / SpartaSite

This repository holds the full source code for The Spartabots website (SpartaSite)
https://spartasite.gam3rr.me
4 stars 7 forks source link

[BUG] (URGENT) {ASSIGNED} Mobile UI is VERY Broken #16

Closed Gam3rrXD closed 3 months ago

Gam3rrXD commented 3 months ago

We need to fix mobile UI, primarily the Splash/Text on each part of the website. This is primarily HTML/CSS with minor JS. 2 current issues are one being the Splash and the 2nd being the navbar, when a mobile Screen Size is detected the Navbar should turn into the Sidebar that we have made, although the Sidebar was also made for desktop so it needs to be tweaked to fit mobile screens.

Sky-De commented 3 months ago

@Gam3rrXD hi there, i would like to take a look and improve it, please assign this to me, thanks

Gam3rrXD commented 3 months ago

sounds good

Sky-De commented 3 months ago

@Gam3rrXD There appears to be a responsiveness issue in multiple routes. , Either those routes that have a link in the navigation or other routes like : /fontDemo, /about, /ourteam, /purchase, /software and ...

Would it be okay if I fix each issue one by one and create separate pull requests for each change on daily basis? This will make it easier to review the code and test each part individually for responsiveness. inform me about it please, Also i provide some gifs of issue on route that exists in nav

Show Case ( wait for load )

Gam3rrXD commented 3 months ago

@Sky-De hi there, this sounds good. some of these endpoints such as /fontDemo are for testing/development purposes so these aren't production issues, everything else is a production issue. as far as the navigation as mentioned in the original issue id like it to use the Sidebar.js. Pull requests are fine, all I need is some sort of indication of what was fixed, I can merge on a daily basis after reviewing each. Thank you!

Sky-De commented 3 months ago

@Gam3rrXD ok then, Thank you for your prompt response. I will start by making the nav bar and main page responsive and creating a pull request for that tonight. Afterward, I will work on the other pages one by one every day till the entire app is responsive.

Gam3rrXD commented 3 months ago

@Sky-De that sounds perfect, thank you again :)

Gam3rrXD commented 3 months ago

image is there anyway to have this text to the left hand side? I tried modifying the text-center part but it doesn't look correct, this is on the mobile ui

Sky-De commented 3 months ago

image is there anyway to have this text to the left hand side? I tried modifying the text-center part but it doesn't look correct, this is on the mobile ui

@Gam3rrXD sure, in upcoming PR i will fix that too!

Gam3rrXD commented 3 months ago

thank you!

eggliot commented 3 months ago

I just noticed when you open the hamburger menu the transition is quite jarring between the new menu and page behind it. Maybe make the blur background take up the whole screen. image

mohit-bhandari45 commented 3 months ago

I want to work on the hamburger issue. Instead I can make a transition of right to left and left to right in hamburger. Assign it to me under gssoc24

Gam3rrXD commented 3 months ago

I want to work on the hamburger issue. Instead I can make a transition of right to left and left to right in hamburger. Assign it to me under gssoc24

sounds good, thank you!

Gam3rrXD commented 3 months ago

A new issue will be opened for the hamburger menu, mobile responsiveness has been resolved!