search

SkylineSpartabots / SpartaSite

This repository holds the full source code for The Spartabots website (SpartaSite)
https://spartasite.gam3rr.me
4 stars 7 forks source link

[ENHANCEMENT] (ASAP) {ASSIGNED} Fix Hamburger Menu #22

Closed Gam3rrXD closed 3 months ago

Gam3rrXD commented 3 months ago 
          I just noticed when you open the hamburger menu the transition is quite jarring between the new menu and page behind it.

Maybe make the blur background take up the whole screen. image

Originally posted by @messier81porcupine in https://github.com/SkylineSpartabots/SpartaSite/issues/16#issuecomment-2108759554

This issue has been ASSIGNED

Gam3rrXD commented 3 months ago

@mohit-bhandari45 this is the issue, submit your PR's here

Sky-De commented 3 months ago

@Gam3rrXD Hi again, I can not see what was the reason for creating this issue, was there anything wrong with the current mobile menu? if there is explain it to me ( why? ) then assign it to me since it is not assigned to anyone else thanks

Gam3rrXD commented 3 months ago

@Gam3rrXD Hi again, I can not see what was the reason for creating this issue, was there anything wrong with the current mobile menu? if there is explain it to me ( why? ) then assign it to me since it is not assigned to anyone else thanks

Oh yea sorry, in the original issue one of my colleagues mentioned that there was some animation issue and he wanted it full screened, I saw that u submitted your last pr for that issue and since this issue wasn't as big I jus made it a new issue, sorry for no heads up.

mohit-bhandari45 commented 3 months ago

I created a PR, you can check

Gam3rrXD commented 3 months ago

I created a PR, you can check

Yes I just saw, I will test on my end then merge, thanks!

Gam3rrXD commented 3 months ago

@Sky-De you can still work on this issue if you feel like it, the provided solution us not what we are looking for.

Sky-De commented 3 months ago

@Sky-De you can still work on this issue if you feel like it, the provided solution us not what we are looking for.

@Gam3rrXD hey, what exactly do you want? Full screen menu with solid background? No transition? Explain what exactly makes this menu as well as you want, thanks

Sky-De commented 3 months ago

@Gam3rrXD Hi, may I ask you a favor? I'd appreciate it if you could take a look at my Portfolio and other projects. Please let me know what you think about them, and if you like them, please give them a STAR. All public projects can be found in the PROJECTS section of my portfolio. Within that section, you can find live demo links as well as repository links related to each project.And if you like my project please mention other colleagues of these projects here to check my Portfolio , thanks thanks

mohit-bhandari45 commented 3 months ago

Hey @Gam3rrXD, do you want this?? image

It is full screen, btw for every screen size!

Gam3rrXD commented 3 months ago

Hey @Gam3rrXD, do you want this?? image

It is full screen, btw for every screen size!

Hi there, yes this is pretty much what I'm looking for, it should only apply to mobile scrensizes, any desktop screen sizes utilize the topbar

mohit-bhandari45 commented 3 months ago

Yes it is like that for mobiles

mohit-bhandari45 commented 3 months ago

Ok i have done it. Are you a part of gssoc24? If yes just add two labels "gssoc24" and "level2" to it and remove the gssoc24(mohit)

mohit-bhandari45 commented 3 months ago

Hey I created a PR, related to this. Please check it.

Gam3rrXD commented 3 months ago

Works perfectly