search

Skynet2-0 / Skynet2.0

GNU General Public License v3.0
2 stars 2 forks source link

Selenium #18

Closed RobvandenBerg closed 8 years ago

RobvandenBerg commented 8 years ago

This contains code that allows Selenium to automatically order a VPS on ZappieHost

StefanBoodt commented 8 years ago

This pull request contains bad coding style with the empty string as default value. When used in this way the default should be none.

In addition can the selenium test.py either conform to the java style tests: seleniumTest.py or to the python style: selenium_test.py. This also makes them automatically runable by tests.sh. If that is unwanted then perhaps it is better to include a {AT_SIGN}unittest.skip{reason} on top to exclude the tests from the unittest run.

StefanBoodt commented 8 years ago

I get an error with the tests:

python: can't open file './submodules/addrgen-master/addrgen.py': [Errno 2] No such file or directory

bash error 2 is misuse of command line built-ins.

Fixed in 005bd9fbcc4087c7288568fdcdc1e887acb0ce80

StefanBoodt commented 8 years ago

The bad style applies to the comments as well. Python putts the comments underneath the function and class names, instead of above them.

StefanBoodt commented 8 years ago

Comment style is fixed, so it could be added, if it worked.